search

code-for-nashville / inclucivics

Data visualization of Nashville Metropolitan Government employee salary and demographics
http://www.codefornashville.org/inclucivics/
MIT License
11 stars 18 forks source link

linting according to yarn test command #194

Closed combinatorist closed 3 years ago

combinatorist commented 3 years ago

@kazshak, FYI, here are additional changes recommended by our linter:


yarn run v1.13.0                                                                                                  
$ yarn standard && react-scripts test --env=jsdom                                                                          
$ /home/qwelk/src/code-for-nashville/inclucivics/node_modules/.bin/standard                                                                  
standard: Use JavaScript Standard Style (https://standardjs.com)                                                           
  /home/qwelk/src/code-for-nashville/inclucivics/scripts/data-fetch.js:19:3: Split initialized 'const' declarations into multiple statements.
  /home/qwelk/src/code-for-nashville/inclucivics/scripts/data-import.js:91:9: Identifier 'dept_regex' is not in camel case.
  /home/qwelk/src/code-for-nashville/inclucivics/scripts/data-import.js:100:7: Identifier 'department_name' is not in camel case.
  /home/qwelk/src/code-for-nashville/inclucivics/scripts/data-import.js:100:25: Expected "[" and "]" to be on the same line
error Command failed with exit code 1.                                                        
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.        
error Command failed with exit code 1.                                                      
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.   ```

But I implemented them, so it passes now.