code-for-venezuela / c4v-py

3 stars 3 forks source link

Luis/toy webscrapper #68

Closed LDiazN closed 3 years ago

LDiazN commented 3 years ago

Important Changes

Problem

Create a toy scraper version to get basic data for El Pitazo, also being able to expand it with more implementations for other sources.

Proposed solution

Tasks

marianelamin commented 3 years ago

no need to push .lock file, since it can be generated with poetry install or update.

asciidiego commented 3 years ago

no need to push .lock file, since it can be generated with poetry install or update.

I think we should (purposely) use lock files. After all, they represent the latest successful build of dependencies of the project. The lock file is safer since it is more specific than just a version number and, therefore, we should always commit it.

asciidiego commented 3 years ago

Just a reminder: whenever the PR is ready for review, remove its draft status, and (I think) it will appear on my Github notification dashboard.

VKorelsky commented 3 years ago

no need to push .lock file, since it can be generated with poetry install or update.

I think we should (purposely) use lock files. After all, they represent the latest successful build of dependencies of the project. The lock file is safer since it is more specific than just a version number and, therefore, we should always commit it.

Agree with this, lock files are usually committed :)