search

code-google-com / bpbible

Automatically exported from code.google.com/p/bpbible
Other
0 stars 0 forks source link

Searches on Strong's Numbers should change versions #101

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Open a Bible without Strong's Numbers (e.g. the ESV).
2. Have a version in the Compare Verses window which does have Strong's
Numbers (e.g. the KJV).
3. Hover over a Strong's word in the KJV and search for it.
4. Since the search is done in the ESV, no results occur.

What is the expected output? What do you see instead?
I expect to see all passages containing that word in the version that I was
in when I made the search (e.g. the KJV).  Instead, I get no results. 
Similar things probably happen if you search for an (English) word from a
version or for other features of a particular version (such as
cross-references), and it searches in a different version.  There are many
words in the KJV that would not occur in the ESV.  It should probably
switch to using the version that the search was made from.

This problem could also be removed if multi-Bible search were the default,
since only results in Bibles with Strong's Numbers / cross-references /
that word would occur.

Workaround
It is possible to change version and then redo the search, but that is ugly
and changes the whole application context, and you then probably want to
switch back at some point.

Original issue reported on code.google.com by jonmmor...@gmail.com on 20 Aug 2009 at 2:45

GoogleCodeExporter commented 9 years ago 
I second that, that's a very useful suggestion for anyone not using KJV by 
default.

Original comment by war...@gmail.com on 15 Apr 2010 at 8:55

GoogleCodeExporter commented 9 years ago

Original comment by jonmmor...@gmail.com on 12 Jun 2010 at 1:08

GoogleCodeExporter commented 9 years ago 
I've had a stab at this.  In r1036 I've changed it so that it changes the 
version being searched in the compare view.  Unfortunately, it also changes the 
current Bible version as a side effect.  This must be completed before 0.4.7.

Original comment by jonmmor...@gmail.com on 5 Jul 2010 at 12:53

GoogleCodeExporter commented 9 years ago 
After trying a lot of different solutions, I think it's too hard to make this 
always do what the user expects (the main problem being "When, if at all, do we 
switch it back from the KJV to the current Bible version?").  However, as it 
now stands it is impossible to switch search from the KJV to the current Bible 
version without changing the current version to something else and back again.  
I've raised issue 170 to cover this.

For now I will just leave it changing the current Bible if you do a Strong's 
search in a different Bible.

Original comment by jonmmor...@gmail.com on 9 Aug 2010 at 12:13

GoogleCodeExporter commented 9 years ago

Original comment by jonmmor...@gmail.com on 9 Aug 2010 at 12:13