search

code-google-com / bpbible

Automatically exported from code.google.com/p/bpbible
Other
0 stars 0 forks source link

Dore Woodcuts module and clicking the image doesn't work #146

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. install Dore Woodcuts (http://ftp.xiphos.org/sword/zip/dorewoodcuts.zip)
2. make sure the Other Books frame is visible
3. navigate to an image and notice that the cursor turns into a pointer 
(like for a hyperlink). But when you click an image, nothing happens.

If run from a terminal, BPBible prints this:
Unknown action 'showImage' u'passagestudy.jsp?
action=showImage&value=file%3A%2Fhome%2Fandreas%2F.sword%2Fmodules%2Fgenboo
k%2Frawgenbook%2Fdorewoodcuts%2Fimages%2Fdore_01_gen01_the_creation_of_ligh
t.jpg&module=DoreWoodcuts'

Is this a bug or missing functionality, or is this a problem with the 
module?

It seems like the OS should launch an image viewer and open the image, like 
Xiphos does.

Original issue reported on code.google.com by war...@gmail.com on 19 Apr 2010 at 6:21

GoogleCodeExporter commented 9 years ago 
This is at present unsupported.

Original comment by jonmmor...@gmail.com on 20 Apr 2010 at 12:33

GoogleCodeExporter commented 9 years ago 
Well here's a patch that implements it. It's probably super-ugly, as I'm not a 
programmer, but it works at least on Linux. I'd appreciate if somebody did more 
testing so it might be included in BPBible.

Original comment by war...@gmail.com on 20 Apr 2010 at 2:11

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixed in r989. Thanks for the patch - I reorganized it a bit and made it work 
with spaces in filenames.

Original comment by benpmor...@gmail.com on 22 Apr 2010 at 12:01

GoogleCodeExporter commented 9 years ago

Original comment by jonmmor...@gmail.com on 22 Apr 2010 at 12:19

GoogleCodeExporter commented 9 years ago 
Great news! Now if only we could get thumbnailing in image modules and we'd be 
all set 
:)

Original comment by war...@gmail.com on 22 Apr 2010 at 6:55

GoogleCodeExporter commented 9 years ago 
With our current HTML viewer it would probably be somewhere between hard and 
impossible 
to do image resizing.  However, the issue tracking it is issue 107.

Original comment by jonmmor...@gmail.com on 23 Apr 2010 at 2:41