Clicking on cross-references fails now?

[GoogleCodeExporter]

Clicking any cross-ref fails on my box, this is bpbible-r1173 on Linux. The 
affected frame just goes blank.

Terminal output:

 Traceback (most recent call last):
  File "/home/*/Apps/bpbible-r1173/gui/webconnect_protocol_handler.py", line 47, in GetContent
    return unicode(protocol_handlers.handlers[protocol].get_document(path))
  File "/home/*/Apps/bpbible-r1173/protocol_handlers.py", line 193, in get_document
    d = self._get_document_parts(path)
  File "/home/*/Apps/bpbible-r1173/protocol_handlers.py", line 350, in _get_document_parts
    config = self.registered.pop(path)
KeyError: 'pop(): dictionary is empty'
Exception KeyError: KeyError('pop(): dictionary is empty',) in 'GetContent' 
ignored
Traceback (most recent call last):
  File "/home/*/Apps/bpbible-r1173/gui/webconnect_protocol_handler.py", line 47, in GetContent
    return unicode(protocol_handlers.handlers[protocol].get_document(path))
  File "/home/*/Apps/bpbible-r1173/protocol_handlers.py", line 193, in get_document
    d = self._get_document_parts(path)
  File "/home/*/Apps/bpbible-r1173/protocol_handlers.py", line 377, in _get_document_parts
    text, module = self.registered.pop(path)
KeyError: 'pop(): dictionary is empty'
Exception KeyError: KeyError('pop(): dictionary is empty',) in 'GetContent' 
ignored

Original issue reported on code.google.com by war...@gmail.com on 18 Jan 2011 at 11:39

[GoogleCodeExporter]

Thanks.  I knew about that, but it turned out to be a bit trickier than 
expected when I last tried to fix it a few days ago and I haven't looked at it 
since.  It will be fixed sometime before 0.5

Original comment by jonmmor...@gmail.com on 19 Jan 2011 at 1:47

• Changed state: Accepted
• Added labels: Type-Defect, Milestone-Release0.5, Priority-High

[GoogleCodeExporter]

Well, this issue means BPBible is basically unusable for now, so I can't test. 
I vaguely recall that a few revisions ago this problem didn't exist. Could you 
tell me how to checkout a specific revision anonymously, not the latest trunk? 

Original comment by war...@gmail.com on 19 Jan 2011 at 9:21

[GoogleCodeExporter]

Judging from the traceback, I was assuming this was just a problem with 
clicking on a cross-reference in a tooltip (which was what I knew about and 
expected).  In my testing, I find the following works:
1. Clicking on cross-references in the tooltip when the cross-references are 
accessed from a letter (Expand Cross References unticked).
2. Clicking on cross-references in the main Bible text when cross-references 
are expanded.

What doesn't work is clicking on cross-references in the tooltip when using 
expand cross-references.  I'm not sure that ever worked.  If you are having it 
fail in the main Bible text then that's not the behaviour I'm getting, and I'd 
like to hear about it.

To get to a specific revision of BPBible, you use svn update -r <revision 
number>.

Original comment by jonmmor...@gmail.com on 19 Jan 2011 at 12:06

[GoogleCodeExporter]

Yes, this is a fail in every fail of BPBible now, that's the point. 

I just checked out r1171, the problem is NOT there. With r1171, indeed, 
clicking a link inside a tooltip fails, but clicking verse references in, say, 
ESV with cross-refs expanded used to work fine.

Now with r1173 literally every link you click fails, the frame the link is in 
just goes blank (same behavior as with links in tooltips in r1171.)

It's almost as if it has smth to do with fixing issue 188, no?

Original comment by war...@gmail.com on 19 Jan 2011 at 3:45

[GoogleCodeExporter]

1. OK, I also checked out r1172. In this revision, you can click expanded 
cross-refs in the main frame fine. So the problem seems to be in r1173?

2. However, in r1172, you can't click Bible version names in Version 
Comparison. The Version Comparison frame goes blank (same behavior as with 
links in tooltips in r1171.)

I just checked, and in r1171 if you couldn't click Bible names in Version 
Comparison either, just hovering the mouse over them threw an exception. Now no 
GUI exception message, just a traceback, and it still doesn't work. Is this a 
separate issue, or is it still issue 188?

Original comment by war...@gmail.com on 19 Jan 2011 at 3:53

[GoogleCodeExporter]

OK, this is very weird. Now clicking links in the main frame with cross-refs 
expanded works again. I didn't do anything, only launched different revisions, 
then switched back to r1173. The links under Version Comparison do not work, 
though.

This is weird, it did NOT work before. Maybe a race condition or maybe there's 
some caching involved someplace?

Original comment by war...@gmail.com on 19 Jan 2011 at 4:07

[GoogleCodeExporter]

OK.  It's possible there is a problem somewhere there, though I wasn't able to 
reproduce it with r1173 (and obviously you haven't been able to after a series 
of changes).  It's also possible that there is a problem with some 
cross-references and passages and not others (I hope not, since it's very hard 
to track down such bugs).

r1173 shouldn't have changed anything to do with this.  r1172 was supposed to 
fix the hover problem, and not affect anything else.

Version comparison book names is a separate issue which is known about.

Original comment by jonmmor...@gmail.com on 20 Jan 2011 at 3:12

[GoogleCodeExporter]

Version comparison book names was fixed in r1175.
Cross-reference clicking should be fixed in r1179 and r1180.

Original comment by jonmmor...@gmail.com on 24 Jan 2011 at 1:33

• Changed state: Fixed

[GoogleCodeExporter]

Thanks, it appears to work so far. However, when you click a verse number in 
the main frame, the Version Comparison doesn't sync with that. Is this related, 
or is it a separate issue?

Original comment by war...@gmail.com on 24 Jan 2011 at 6:40

[GoogleCodeExporter]

That was a separate but related problem.  I've fixed it in r1181.

Original comment by jonmmor...@gmail.com on 25 Jan 2011 at 7:12