search

code-google-com / bullet

Automatically exported from code.google.com/p/bullet
0 stars 0 forks source link

Unicode bug in Win32ThreadSupport::startThreads() #320

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If you build with Bullet with unicode enabled you get 2 compile errors in 
Win32ThreadSupport::startThreads().

The fix is to change the CreateEvent to CreateEventA.

Original issue reported on code.google.com by fcukg00gl3@gmail.com on 18 Dec 2009 at 11:26

GoogleCodeExporter commented 9 years ago 

Should it be CreateEventA for all windows platforms, or only for unicode builds?

Original comment by erwin.coumans on 18 Dec 2009 at 4:51

GoogleCodeExporter commented 9 years ago 
It should build with any version of Windows AFAIK.

CreateEvent is actually a #define that returns either CreateEventA or 
CreateEventW 
based on it being ascii or unicode/widechar mode.

The problem with just using CreateEvent in unicode mode is that the string is 
ascii 
and would need to be converted.

By saying CreateEventA your forcing it to use the ascii path and there is no 
need to 
convert the string.

Original comment by fcukg00gl3@gmail.com on 18 Dec 2009 at 11:12

GoogleCodeExporter commented 9 years ago 
Ok, it has been fixed in latest trunk:
http://code.google.com/p/bullet/source/detail?r=1865

Thanks for the report+fix!
Erwin

Original comment by erwin.coumans on 21 Dec 2009 at 11:58