code-google-com / bullet

Automatically exported from code.google.com/p/bullet
0 stars 0 forks source link

Eliminate gcc warnings from Bullet headers #330

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. include bullet headers in your project
2. compile your project with warnings turned on
3.

What is the expected output? What do you see instead?
no warnings from bullet

warnings from bullet

What version of the product are you using? On what operating system?
svn, linux

Please provide any additional information below.
These warnings are mostly 'parameter not used' which is fine 99% of the
time but 1% of the time indicates a typo or other bug that would otherwise
be hard to find.

The other warnings are due to constructors not being called.

Original issue reported on code.google.com by d...@doc.ic.ac.uk on 16 Jan 2010 at 3:38

Attachments:

GoogleCodeExporter commented 9 years ago

It seems in many cases a virtual method should have made pure virtual instead 
of 
leaving an empty implementation, without using any of the parameters.

Thanks for the patch, it has been applied:
http://code.google.com/p/bullet/source/detail?r=1879

Original comment by erwin.coumans on 19 Jan 2010 at 6:10