code-google-com / bullet

Automatically exported from code.google.com/p/bullet
0 stars 0 forks source link

Assert when trying to add unsupported child shapes to btCompoundShape #348

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

http://bulletphysics.org/Bullet/phpBB3/viewtopic.php?
f=9&t=4802&p=17718#p17718

The original intend for btCompoundShape was to allow btConvexShape child 
shape, and possibly recursive btCompoundShape (a btCompoundShape as child 
shape). We didn't restrict the API to this, so developers start adding all 
kind of shapes to btCompoundShape, including btBvhTriangleMeshShape, 
btGimpactMeshShape, btStaticPlaneShape etc.

This is not ok and a support drag. We should add an assert, but keep the 
option open for advanced users who know how to work around the issues:

/// If you want to add unsupported child shapes, you can set 
assertOnUnsupportedChildShape to false. 
/// If things don't work as expected (for example adding a 
btGimpactMeshShape to a btCompoundShape), you will likely have to fix 
issues yourself.
btCompoundShape::addChildShape(const btTransform& 
localTransform,btCollisionShape* shape, bool 
assertOnUnsupportedChildShape=true);

Original issue reported on code.google.com by erwin.coumans on 2 Mar 2010 at 7:56

GoogleCodeExporter commented 9 years ago

Url was truncated, here again: http://tinyurl.com/yepy767

Original comment by erwin.coumans on 2 Mar 2010 at 7:56

GoogleCodeExporter commented 9 years ago
If this is done, can you also summarize the relevant issues in the 
documentation?  In the referenced thread, it is unclear if there are any issues 
besides btInternalEdgeUtility not working properly.

Original comment by paul.dubois@gmail.com on 16 Jun 2010 at 6:42

GoogleCodeExporter commented 9 years ago
Closing issues that we are not fixing anymore, we try to keep the Bullet 2.x 
API stable and just apply some bug fixes and apply patches with big features.

Our focus is on Bullet 3.x at http://github.com/erwincoumans/bullet3

Thanks for bringing this up anyway,
Erwin

Original comment by erwin.coumans on 11 Sep 2013 at 12:15