search

code-google-com / opencollada

Automatically exported from code.google.com/p/opencollada
0 stars 0 forks source link

Support for VS2005 and VS2010 #152

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
> What steps will reproduce the problem?

On Windows, OpenCollada (at r797) can successfully be compiled and linked with 
VS2008, but not with VS2005 or VS2010. The problems are all related to hash 
maps header include files and related API details, that differ across compiler 
versions.

> What is the expected output? What do you see instead?

The goal is successful compilation with VS2005 and VS2010 as well.

> What version of the product are you using? On what operating system?

OpenCollada at r797, using
VS2005 on Windows 2000,
VS2010 on Windows 7.

> Please provide any additional information below.

I attach a patch that fixes the issue.

Also see issue 120, which this issue supersedes, because issue 120 is concerned 
with VS2010 only, while this patch makes OpenCollada work with both VS2005 and 
VS2010, and is shorter and enhances code readability.

Also see issue 133, which might be affected and possibly superseded by this 
issue as well.

Additionally, the patch replaces the cumbersome C preprocessor magic for 
dealing with the differences in hash map details across compilers.
The new preprocessor statements are short, clear, and much easier to read and 
to extend to additional compilers and compiler versions. ;-)

The patch has been tested under the following OS'es and compilers:
  - Windows 2000 with VS2005,
  - Windows 7 with VS2010,
  - Ubuntu 10.10 with GCC 4.4 (x86),
  - Ubuntu 10.10 with GCC 4.4 (x86_64).

These are the systems that we also use for our game and graphics engine 
http://www.cafu.de - sorry for having at this time not been able to test it 
under Mac OS and earlier versions of GCC as well.

Original issue reported on code.google.com by carsten....@cafu.de on 16 Jan 2011 at 12:59

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixes issue 133 for me. 

That is building with gcc 4.2.4 ubuntu 8.04 on both x86 and amd64.

Original comment by martijn....@gmail.com on 16 Jan 2011 at 4:17

GoogleCodeExporter commented 9 years ago 
Thanks a lot for providing this patch.
It has been applied in revision 798.

Original comment by opencollada2@googlemail.com on 17 Jan 2011 at 8:08

GoogleCodeExporter commented 9 years ago 
Thanks for very quick review and application, this helps me a lot to keep 
things organized here.  :-)

Original comment by carsten....@cafu.de on 17 Jan 2011 at 2:21