Compilation error

[GoogleCodeExporter]

A compilation error occurs while compiling PyV8 -r557 / V8 -r17998

src/Engine.cpp: In static member function 'static bool 
CEngine::SetMemoryLimit(int, int, int)':
src/Engine.cpp:357:43: error: cannot convert 'v8::ResourceConstraints*' to 
'v8::Isolate*' for argument '1' to 'bool 
v8::SetResourceConstraints(v8::Isolate*, v8::ResourceConstraints*)'
error: command 'x86_64-pc-linux-gnu-g++' failed with exit status 1

Additional information

buffer@rigel ~/v8 $ svn info
Path: .
Working Copy Root Path: /home/buffer/v8
URL: http://v8.googlecode.com/svn/trunk
Repository Root: http://v8.googlecode.com/svn
Repository UUID: ce2b1a6d-e550-0410-aec6-3dcde31c8c00
Revision: 18011
Node Kind: directory
Schedule: normal
Last Changed Author: machenbach@chromium.org
Last Changed Rev: 17998
Last Changed Date: 2013-11-22 11:04:21 +0100 (Fri, 22 Nov 2013)

buffer@rigel ~/pyv8 $ svn info
Path: .
Working Copy Root Path: /home/buffer/pyv8
URL: http://pyv8.googlecode.com/svn/trunk
Repository Root: http://pyv8.googlecode.com/svn
Repository UUID: 3b770cb8-f9e6-11dd-ac5b-dfceb64ead24
Revision: 557
Node Kind: directory
Schedule: normal
Last Changed Author: flier.lu@gmail.com
Last Changed Rev: 557
Last Changed Date: 2013-11-11 06:33:18 +0100 (Mon, 11 Nov 2013)

Original issue reported on code.google.com by angelo.d...@gmail.com on 22 Nov 2013 at 1:22

[GoogleCodeExporter]

Thanks, just remove preemption mode threads, Please try the latest SVN trunk 
code after r558

Original comment by flier...@gmail.com on 25 Nov 2013 at 7:06

• Changed state: Fixed
• Added labels: OpSys-All

[GoogleCodeExporter]

Issue 214 has been merged into this issue.

Original comment by flier...@gmail.com on 25 Nov 2013 at 7:06

[GoogleCodeExporter]

I confirm the patch solves the issue.

Original comment by angelo.d...@gmail.com on 25 Nov 2013 at 8:26