oss and oss4 plug-ins don't accept dsp device on v0.5.x

code-google-com / qmmp

Automatically exported from code.google.com/p/qmmp

0 stars 0 forks source link

oss and oss4 plug-ins don't accept dsp device on v0.5.x #483

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Set to use the OSS output plug-in with applying /dev/dsp0.0 for its device.
2. Update to 0.5.x.  (0.4.x works well.)
3. Play a recorded item.

What is the expected output? What do you see instead?
Playback doesn't work as well as it sounds nothing and it gives
"OutputOSS: ioctl SNDCTL_DSP_SETFMT failed: Invalid arguments" error.

What version of the product are you using? On what operating system?
QMMP version 0.5.1
OS: FreeBSD 8.2-STABLE

Please provide any additional information below.
Giving the same device (/dev/dsp0.0), the OSS output of 0.4.5 sounds well
without errors.  Switching to the OSS4 plugin with /dev/dsp0.1 that appears
after activating `soundon' command, audio output and playback function also 
fail.

Original issue reported on code.google.com by liangtai.s4@gmail.com on 10 Jul 2011 at 6:51

GoogleCodeExporter commented 9 years ago

Try this patch.

Original comment by trialuser02 on 13 Jul 2011 at 4:55

Attachments:

oss.diff

GoogleCodeExporter commented 9 years ago

>Try this patch.
Then the program doesn't show the same error above. but when pushing
'play' button, the application quits itself with a sequence of messages
 |OutputOSS: unsupported audio format
 |ASSERT: "m_chan == 0" in file qmmpaudioengine.cpp, line 329
 |Abort
before playing an audio item.

Original comment by liangtai.s4@gmail.com on 14 Jul 2011 at 2:37

GoogleCodeExporter commented 9 years ago

I'm sorry. This patch is broken. Try new one please.

Original comment by trialuser02 on 18 Jul 2011 at 7:32

Changed state: Accepted

Attachments:

oss.diff

GoogleCodeExporter commented 9 years ago

Thank you more!

I applied the second patch.  Unfortunately, QMMP fails again
and shows messages as follows:
 |OutputOSS: ioctl SNDCTL_DSP_SETFMT failed: Invalid argument
 |ASSERT: "m_chan == 0" in file qmmpaudioengine.cpp, line 329
 |Abort

As an additional information, I found the OSS4 plugin also
fails with a sequence of quite identical messages to the above
except that begins with OutputOSS4:
 |OutputOSS4: ioctl SNDCTL_DSP_SETFMT failed: Invalid argument
 |ASSERT: "m_chan == 0" in file qmmpaudioengine.cpp, line 329
 |Abort

Original comment by liangtai.s4@gmail.com on 20 Jul 2011 at 5:49

GoogleCodeExporter commented 9 years ago

Please, try again.

Original comment by trialuser02 on 27 Jul 2011 at 4:42

Attachments:

oss2.diff

GoogleCodeExporter commented 9 years ago

I confirm that the OSS (and OSS4) plugin doesn't work under FreeBSD (in my case 
9.0-RC3), it doesn't crash rather it plays noise. Null output plugin seems to 
play correctly, as guessed by the spectrum analyzer.

Original comment by yks....@gmail.com on 21 Dec 2011 at 12:53

GoogleCodeExporter commented 9 years ago

I confirm that OSS/OSS4 plugin does not accept default sound device /dev/dsp 
(FreeBSD 10.0-CURRENT). To get it working I need to explicitly define a virtual 
channel like /dev/dsp1.vp0 or so. 
Please fix it!

Original comment by artjom.g...@gmail.com on 9 Feb 2012 at 11:59

GoogleCodeExporter commented 9 years ago

Now both of 0.5.5-r2710 and 0.6-r2710 perfectly work with OSS4 plugin, that
means I believe r2698, and r2699 for trunk/ resolved this problem, as well
as r2672, r2673, r2674, and r2675 for branches/qmmp-0.5 do.

built with: FreeBSD-9.0-STABLE / clang++

Thank you, very happy!

Original comment by liangtai.s4@gmail.com on 8 Apr 2012 at 8:27

GoogleCodeExporter commented 9 years ago

Original comment by trialuser02 on 29 Jun 2012 at 2:00

Changed state: Fixed