code-hike / codehike

Build rich content websites with Markdown and React
https://codehike.org
MIT License
4.68k stars 142 forks source link

bug with the new linenumbers feature? #112

Closed cabljac closed 2 years ago

cabljac commented 2 years ago

Hey there, was testing out your new line numbers feature in the pre-release, just with some codeblocks identical to the demo examples, seems to break some of them, unless i've done something wrong -

I just included the option lineNumbers: true and updated to "@code-hike/mdx": "^v0.3.0-next.20"

Screenshot 2022-01-17 at 10 19 16
cabljac commented 2 years ago

this could be due to some extra styling im adding somewhere, will double check and get back to you.

pomber commented 2 years ago

Yes, please, if you have more info post it. Does it happen only with lineNumbers: true?

cabljac commented 2 years ago

no it seemed to happen with or without, and the content is there, just hidden under some overflow

pomber commented 2 years ago

If you could share a minimal repro I'll debug it

cabljac commented 2 years ago

I'll try, just a sec :)

cabljac commented 2 years ago

OK bug is with my code not codehikes, thanks for the quick response anyway!

cabljac commented 2 years ago

I believe it's some clash with my tailwind styles, but there's too much going on to set up a quick repro rn

pomber commented 2 years ago

Let me know if you still need help, also if you find the problem let me know, I want to try to prevent similar issues.

cabljac commented 2 years ago

seems to be working now, i think it was actually a cache issue