code-hike / codehike

Build rich content websites with Markdown and React
https://codehike.org
MIT License
4.74k stars 146 forks source link

feat(#246): Add onChange and initialSlideIndex props to CH.Slideshow #248

Closed brianespinosa closed 2 years ago

brianespinosa commented 2 years ago

Resolves #246

For the proposed use case, it is not enough to only initialize the Slideshow component with a starting slide. There also needed to be a way to expose the current slide so that someone could use that value to set in the current URL.

Published prerelease version: v0.7.3-next.2

Changelog #### πŸ› Bug Fix - `@code-hike/mdx` - feat(#246): Add onChange and initialSlideIndex props to CH.Slideshow [#248](https://github.com/code-hike/codehike/pull/248) ([@brianespinosa](https://github.com/brianespinosa)) - Fix typescript module resolution [#249](https://github.com/code-hike/codehike/pull/249) ([@pomber](https://github.com/pomber)) - feat(244): Allow Slideshow controls to autoFocus [#245](https://github.com/code-hike/codehike/pull/245) ([@brianespinosa](https://github.com/brianespinosa) [@pomber](https://github.com/pomber)) #### ⚠️ Pushed to `next` - Update bundle_analysis.yml ([@pomber](https://github.com/pomber)) #### Authors: 2 - Brian Espinosa ([@brianespinosa](https://github.com/brianespinosa)) - Rodrigo Pombo ([@pomber](https://github.com/pomber))
vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
chtest βœ… Ready (Inspect) Visit Preview Jul 29, 2022 at 5:52PM (UTC)
playground βœ… Ready (Inspect) Visit Preview Jul 29, 2022 at 5:52PM (UTC)
pomber commented 2 years ago

Thanks a lot for the PRs @brianespinosa! I'll take a look later.

One small thing: can you disable the thing that reorders the props for future PRs? It makes the review harder.

brianespinosa commented 2 years ago

One small thing: can you disable the thing that reorders the props for future PRs? It makes the review harder.

Sorry... that's actually me and my OCD sorting alphabetically by habit. I'll make sure not to do that on other PRs.

Is there a logical method you're using to sort these props and objects so I can follow that in the future?

pomber commented 2 years ago

Is there a logical method you're using to sort these props and objects so I can follow that in the future?

chaos

github-actions[bot] commented 2 years ago

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

This PR introduced no changes to the javascript bundle πŸ™Œ

pomber commented 2 years ago

Looks good, thank you!

github-actions[bot] commented 2 years ago

:rocket: PR was released in v0.7.3 :rocket: