code-hike / codehike

Marvellous code walkthroughs
https://codehike.org
MIT License
4.39k stars 135 forks source link

feat(#217): CH.Slideshow autoPlay and autoPlayLoop #250

Closed brianespinosa closed 1 year ago

brianespinosa commented 1 year ago

Resolves #217

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chtest ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 10:52AM (UTC)
playground ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 10:52AM (UTC)
github-actions[bot] commented 1 year ago

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

brianespinosa commented 1 year ago

If you merge the other PR and there are conflicts here, @ me if you want me to go through to resolve them. 👍🏽

pomber commented 1 year ago

Thank you.

brianespinosa commented 1 year ago
  • I think we should call the props autoPlay and loop, similar to the HTML video element attributes

Done.

  • Can you remove the framer-motion dependency?

Yikes. I accidentally branched from the wrong spot on my end where I was trying to see if I could get presence animation working for motion components in slides. Luckily there were not many changes to back out.

  • I may add some changes on top of yours if you don't mind

Go for it.

Conflicts resolved from the previous branch merge.

github-actions[bot] commented 1 year ago

:rocket: PR was released in v0.7.3 :rocket: