Closed brianespinosa closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
chtest | ✅ Ready (Inspect) | Visit Preview | Sep 1, 2022 at 10:52AM (UTC) |
playground | ✅ Ready (Inspect) | Visit Preview | Sep 1, 2022 at 10:52AM (UTC) |
This analysis was generated by the next.js bundle analysis action 🤖
This PR introduced no changes to the javascript bundle 🙌
If you merge the other PR and there are conflicts here, @ me if you want me to go through to resolve them. 👍🏽
Thank you.
autoPlay
and loop
, similar to the HTML video element attributesframer-motion
dependency?
- I think we should call the props
autoPlay
andloop
, similar to the HTML video element attributes
Done.
- Can you remove the
framer-motion
dependency?
Yikes. I accidentally branched from the wrong spot on my end where I was trying to see if I could get presence animation working for motion components in slides. Luckily there were not many changes to back out.
- I may add some changes on top of yours if you don't mind
Go for it.
Conflicts resolved from the previous branch merge.
:rocket: PR was released in v0.7.3
:rocket:
Resolves #217
autoPlay
andautoPlayLoop
to CH.Slideshow component.slideNext()
andslidePrevious()
to make code easier to follow and DRY when used in useEffectautoPlayLoop
is not configured, prevent side effect and timeout are not called againautoPlayLoop
is configured, an additional timeout is set to allow the last slide to show before resetting to the beginning slideautoPlay
is not configured.