code-hike / codehike

Marvellous code walkthroughs
https://codehike.org
MIT License
4.39k stars 135 forks source link

fix: overscroll behaviour for code blocks #251

Closed MarkusWendorf closed 1 year ago

MarkusWendorf commented 1 year ago

I found an issue with code blocks that block the user from scrolling the whole page, because overflow: auto catches the scroll and does not propagate it to the document.

Repro for the issue: https://github.com/MarkusWendorf/codehike-overscroll

This PR fixes that behaviour by adding overscroll-behaviour: "auto" to ch-code-scroll-parent.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chtest ✅ Ready (Inspect) Visit Preview Jul 30, 2022 at 1:09PM (UTC)
playground ✅ Ready (Inspect) Visit Preview Jul 30, 2022 at 1:09PM (UTC)
pomber commented 1 year ago

Thanks for looking into it. Have you tried the latest version? I think I fixed this with #241

MarkusWendorf commented 1 year ago

Yes v0.7.3-next.2 does the trick. Closed.