code-hike / codehike

Build rich content websites with Markdown and React
https://codehike.org
MIT License
4.74k stars 146 forks source link

Vfile TypeScript issues (v0.7.3-next.1) #252

Closed MarkusWendorf closed 2 years ago

MarkusWendorf commented 2 years ago

The typescript resolution changes introduced by https://github.com/code-hike/codehike/pull/249 seems to surface an issue with the vfile / unified dependency.

StackBlitz forked from contentlayer example: https://stackblitz.com/edit/github-szrmjr?file=contentlayer.config.ts

Seems to be a version mismatch since between vfile v5 and vfile v4 (contents renamed to value) used by unified.

pomber commented 2 years ago

Thanks! I'll take a look later, any ideas on how to fix it?

MarkusWendorf commented 2 years ago

@pomber I think the issue is that content layer uses the unified v10 with vfile v5 and code hike is still on unified v9 with vfile v4.

I guess upgrading unified to v10 would solve the issue.

github-actions[bot] commented 2 years ago

:rocket: Issue was released in v0.7.3 :rocket: