search

code-hike / codehike

Marvellous code walkthroughs
https://codehike.org
MIT License
4.39k stars 135 forks source link

fix: use semantic elements #341

Closed mfranzke closed 1 year ago

mfranzke commented 1 year ago

especially for accessibility reasons; to e.g. have those announced correctly by screenreaders and even also make them reachable on keyboard usage.

Resolves https://github.com/code-hike/codehike/issues/335

Version

Published prerelease version: v0.8.2-next.0

Changelog #### 🐛 Bug Fix - `@code-hike/mdx` - fix: use semantic elements [#341](https://github.com/code-hike/codehike/pull/341) ([@mfranzke](https://github.com/mfranzke) [@pomber](https://github.com/pomber)) #### Authors: 3 - Maximilian Franzke ([@mfranzke](https://github.com/mfranzke)) - Rodrigo Pombo ([@pomber](https://github.com/pomber)) - Yangshun Tay ([@yangshun](https://github.com/yangshun))
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chtest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 11:37am
playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 11:37am
pomber commented 1 year ago

thanks, I'll take a look later. (maybe you can search for examples of others resetting the button's browser default styles to see if anything is missing)

Mantish commented 1 year ago

Awesome, this is exactly what we need to fix #335

pomber commented 1 year ago

Sorry for the delay. I'll try to merge it this week.

pomber commented 1 year ago

I added the button element to a few more buttons and created a reset-button mixin. Also rolled back the changes to tabs, that's harder and we have another issue for that.

Thank you all.

github-actions[bot] commented 1 year ago

:rocket: PR was released in v0.8.2 :rocket: