code-hike / codehike

Marvellous code walkthroughs
https://codehike.org
MIT License
4.39k stars 135 forks source link

Replace buttons by tab component #344

Open mfranzke opened 1 year ago

mfranzke commented 1 year ago
          Just a passing suggestion (maybe not something to implement here in this PR, but just a thought).

I would maybe suggest using an accessible UI foundation package for the editor (which is essentially a Tabs component, I think?). There are quite a few keyboard interactions (e.g. roving focus) that are a bit tricky to get right when rolling your own.

For comparison's sake, here are a few that I know of, off the top of my head:

_Originally posted by @melanieseltzer in https://github.com/code-hike/codehike/pull/341#discussion_r1150973712_

melanieseltzer commented 1 year ago

Thanks for opening this and surfacing my suggestion @mfranzke 👍

@pomber I would be happy to help work on implementation if you are open to it.

stern-shawn commented 11 months ago

+1 for this!