code-iai / ROSIntegration

Unreal Engine Plugin to enable ROS Support
MIT License
412 stars 133 forks source link

std_msgs/Header time vs. stamp in docs #138

Open samkys opened 4 years ago

samkys commented 4 years ago

Is there intent behind having the std_msgs/Header time name be time instead of stamp?

Where name is time at line 20: https://github.com/code-iai/ROSIntegration/blob/master/Source/ROSIntegration/Public/std_msgs/Header.h

And in docs where name is stamp: http://docs.ros.org/en/melodic/api/std_msgs/html/msg/Header.html

Thanks!

Sanic commented 3 years ago

Hi @samkys If there was an intent in that naming, i can't really remember what it was 😃

From my side it would be worth a try to rename it and see if other things break.

samkys commented 3 years ago

Cool, next time I'm working on that I'll make a change and see what happens.