code-iai / iai_kinect2

Tools for using the Kinect One (Kinect v2) in ROS
Apache License 2.0
881 stars 519 forks source link

build on noetic / ubuntu focal #577

Closed Rubiaceae65 closed 2 years ago

remmel commented 2 years ago

That code makes the rgb image scaled. Because of using cv::COLOR_BGR2RGB instead of COLOR_BGRA2BGR or cv::COLOR_BGR2RGB instead of cv::COLOR_BGR2GRAY

remmel commented 2 years ago

Also there are missing Macro see last file in https://github.com/cbuchxrn/iai_kinect2_opencv4/commit/7123381392f2524f1f85713bb92ab1f2e768190f #elif CV_MAJOR_VERSION == 3 -> #elif CV_MAJOR_VERSION == 3 || CV_MAJOR_VERSION == 4 twice

Rubiaceae65 commented 2 years ago

ah, yes, indeed this does not work, closing it