search

code-iai / snap_map_icp

Module for relocalizing a ROS-enabled robot based on it's base laser readings and matching them with the currently advertised /map topic.
23 stars 35 forks source link

Hydro/catkin support #2

Closed mh0rst closed 10 years ago

mh0rst commented 10 years ago

During our migration to hydro, I converted the SnapMap package to catkin and made it compatible with pcl 1.7. This is the result, it is not pretty and the package name does not conform with catkin naming conventions, but it works with groovy and hydro in a catkin workspace. In groovy, you need to rosdep install SnapMapICP first to get the pcl 1.7 library.

airballking commented 10 years ago

@mh0rst Sorry for not assigning this pull request to anyone. We totally slept on this. Any technical reason why you closed it?

mh0rst commented 10 years ago

@airballking Yeah, I saw that the PR was targeting the master branch which I do not want because it would break compatibility with standard ROS groovy installations (pcl incompatibility and catkin naming convention). I'd rather leave my changes in a hydro-devel (or similar) branch so users would have to actively choose it. EDIT: Creating new upstream branches via PRs is not possible (see http://stackoverflow.com/questions/9796370/github-pull-request-to-a-new-upstream-branch), if someone with push permission creates a hydro-devel branch, I can recreate a new PR targetting that branch.

airballking commented 10 years ago

@mh0rst I just created a hydro-devel branch. Could you please open up a new pull request with your fix? Thank you.