search

code-kern-ai / bricks

Open-source natural language enrichments at your fingertips.
Apache License 2.0
451 stars 23 forks source link

[MODULE] - Percentage extraction #149

Open divyanshukatiyar opened 1 year ago

divyanshukatiyar commented 1 year ago

Description Given a text, I want to extract all the occurrences of the percentages with numerical values.

Implementation? A regex can be used for this case.

Additional context Add any other context or screenshots about the feature request here.

rasdani commented 1 year ago

I can take a shot at this :) Seems like a nice issue to warm up and get familiar with the module structure.

rasdani commented 1 year ago

PR #267

LeonardPuettmannKern commented 1 year ago

Implemented with PR #267. Thanks @rasdani :)

jhoetter commented 1 year ago

@LeonardPuettmannKern minor thing, but the tabler icon isn't showing up on the bricks cms. Can you look into that? maybe just a typo or something in the configs

LeonardPuettmannKern commented 1 year ago

thanks @jhoetter ! will have a look!

LeonardPuettmannKern commented 1 year ago

Fixed the icon on the cms and opened a PR. Closing again once its merged.

SvenjaKern commented 1 year ago

I found a small issue in the Refinery: YOUR_REGEX, YOUR_ATTRIBUTE & YOUR_LABEL has to be changed to REGEX, ATTRIBUTE & LABEL Otherwise top :)