[BUG] - data browser filter for empty doesn't work - Githubissues

code-kern-ai / refinery

The data scientist's open-source choice to scale, assess and maintain natural language data. Treat training data like a software artifact.

https://www.kern.ai

Apache License 2.0

1.4k stars 68 forks source link

[BUG] - data browser filter for empty doesn't work #219

Closed JWittmeyer closed 1 year ago

JWittmeyer commented 1 year ago

Describe the bug filtering for equal empty return all records an not just the ones with no entry

To Reproduce Steps to reproduce the behavior:

Go to data browser
Expand attributes
Change filter to equal
(Any attribute equal '')
all records are shown

Expected behavior only show the ones with at least one attribute none existent

Screenshots

Desktop (please complete the following information):

OS: Windows
Browser chrome
Version 1.7.1 dev (so more like 1.8.0)

Additional context happens for both any attribute and specific attribute selected

lumburovskalina commented 1 year ago

Steps to implement:

What is the core solution? -->
1. Debugging where the issue occurs - FE/BE? (1h)
2. Probably BE? - fixing condition in sql query - searching for none existent attributes (1h)
3. Applied for both Any attribute and specific attribute (15minutes)
What problems could be expected? --> no additional time
UI changes and notifications? --> no additional time

Steps for testing:

Testing if all filters work as expected (15minutes)

Steps for review:

Review (15minutes)
Fixing comments from PR (15minutes- 30minutes)

ESTIMATION:

Implementation: 2h 15min
Testing: 15min
Review: 30minutes - 45minutes

TOTAL ESTIMATION: 3h - 3h 15minutes