code-lts / doctum

A php API documentation generator, fork of Sami
https://doctum.long-term.support/
MIT License
300 stars 32 forks source link

fix: loop over forward slashes for relative dir, replace after urlencode #64

Open tiller1010 opened 10 months ago

tiller1010 commented 10 months ago

Fixes #63

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (78ee960) 63.99% compared to head (120ef45) 63.99%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v5.5.x #64 +/- ## ========================================= Coverage 63.99% 63.99% Complexity 1252 1252 ========================================= Files 53 53 Lines 3611 3611 ========================================= Hits 2311 2311 Misses 1300 1300 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

williamdes commented 7 months ago

Update: I am a bit unsatisfied about the current code, maybe I will refactor it a bit before merging this We should not have to split the path and re build it, it feels wrong