code-pushup / cli

A CLI to run all kinds of code quality measurements to align your team with company goals
https://code-pushup.dev
MIT License
208 stars 12 forks source link

test(nx-plugin-e2e): refactor to use new test helper #785

Closed BioPhoton closed 1 month ago

BioPhoton commented 1 month ago

Precondition of #773

Included changes:

github-actions[bot] commented 1 month ago

Code PushUp

๐Ÿคจ Code PushUp report has both improvements and regressions โ€“ compared target commit 068ffb90c417e2dc2d56a81aee59c6416a403760 with source commit 1041524d4bb3af3d7b2c68d9339f38ecf0238499.

๐Ÿ•ต๏ธ See full comparison in Code PushUp portal ๐Ÿ”

๐Ÿท๏ธ Categories

๐Ÿท๏ธ Category โญ Previous score โญ Current score ๐Ÿ”„ Score change
Performance ๐Ÿ”ด 45 ๐ŸŸก 52 โ†‘ +6.8
Code coverage ๐ŸŸก 90 ๐ŸŸก 90 โ†‘ +0
Custom checks ๐ŸŸก 67 ๐ŸŸก 67 โ€“
Security ๐ŸŸข 100 ๐ŸŸข 100 โ€“
Updates ๐ŸŸก 78 ๐ŸŸก 78 โ€“
Accessibility ๐ŸŸข 91 ๐ŸŸข 91 โ€“
Best Practices ๐ŸŸข 100 ๐ŸŸข 100 โ€“
SEO ๐ŸŸก 61 ๐ŸŸก 61 โ€“
Bug prevention ๐ŸŸข 100 ๐ŸŸข 100 โ€“
Code style ๐ŸŸข 99 ๐ŸŸข 99 โ€“

๐Ÿ—ƒ๏ธ Groups

๐Ÿ‘ 2 groups improved | ๐Ÿ”Œ Plugin | ๐Ÿ—ƒ๏ธ Group | โญ Previous score | โญ Current score | ๐Ÿ”„ Score change | | :--------------------------------------------------------------------------- | :-------------------- | :--------------: | :-------------: | :--------------------------------------------------------------: | | Lighthouse | Performance | ๐Ÿ”ด 45 | ๐ŸŸก **52** | ![โ†‘ +6.8](https://img.shields.io/badge/%E2%86%91%20%2B6.8-green) | | [Code coverage](https://www.npmjs.com/package/@code-pushup/coverage-plugin/) | Code coverage metrics | ๐ŸŸก 90 | ๐ŸŸก **90** | ![โ†‘ +0](https://img.shields.io/badge/%E2%86%91%20%2B0-green) | 18 other groups are unchanged.

๐Ÿ›ก๏ธ Audits

๐Ÿ‘ 5 audits improved, ๐Ÿ‘Ž 1 audit regressed, 14 audits changed without impacting score | ๐Ÿ”Œ Plugin | ๐Ÿ›ก๏ธ Audit | ๐Ÿ“ Previous value | ๐Ÿ“ Current value | ๐Ÿ”„ Value change | | :--------------------------------------------------------------------------- | :------------------------------------------- | :------------------------------: | :---------------------------------: | :---------------------------------------------------------------------------------: | | Lighthouse | First Contentful Paint | ๐ŸŸฅ 3.2ย s | ๐ŸŸจ **2.5ย s** | ![โ†“ โˆ’22โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%9222%E2%80%89%25-green) | | Lighthouse | First Meaningful Paint | ๐ŸŸจ 3.4ย s | ๐ŸŸจ **2.5ย s** | ![โ†“ โˆ’25โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%9225%E2%80%89%25-green) | | Lighthouse | Largest Contentful Paint | ๐ŸŸจ 3.8ย s | ๐ŸŸจ **3.3ย s** | ![โ†“ โˆ’14โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%9214%E2%80%89%25-green) | | Lighthouse | Speed Index | ๐ŸŸฅ 7.6ย s | ๐ŸŸฅ **7.2ย s** | ![โ†“ โˆ’5โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%925%E2%80%89%25-green) | | [Code coverage](https://www.npmjs.com/package/@code-pushup/coverage-plugin/) | Line coverage | ๐ŸŸฉ 91.6 % | ๐ŸŸฉ **91.6 %** | ![โ†“ +0โ€‰%](https://img.shields.io/badge/%E2%86%93%20%2B0%E2%80%89%25-red) | | [Code coverage](https://www.npmjs.com/package/@code-pushup/coverage-plugin/) | Branch coverage | ๐ŸŸจ 84.3 % | ๐ŸŸจ **84.3 %** | ![โ†‘ +0โ€‰%](https://img.shields.io/badge/%E2%86%91%20%2B0%E2%80%89%25-green) | | Lighthouse | Avoids enormous network payloads | ๐ŸŸฉ Total size was 1,798ย KiB | ๐ŸŸฉ **Total size was 1,790ย KiB** | ![โ†“ +0โ€‰%](https://img.shields.io/badge/%E2%86%93%20%2B0%E2%80%89%25-gray) | | Lighthouse | Eliminate render-blocking resources | ๐ŸŸฅ Potential savings of 1,580ย ms | ๐ŸŸฅ **Potential savings of 580ย ms** | ![โ†“ โˆ’63โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%9263%E2%80%89%25-gray) | | Lighthouse | Uses efficient cache policy on static assets | ๐ŸŸจ 27 resources found | ๐ŸŸจ **27 resources found** | ![โ†‘ +0โ€‰%](https://img.shields.io/badge/%E2%86%91%20%2B0%E2%80%89%25-gray) | | Lighthouse | JavaScript execution time | ๐ŸŸฅ 10.4ย s | ๐ŸŸฅ **10.9ย s** | ![โ†‘ +5โ€‰%](https://img.shields.io/badge/%E2%86%91%20%2B5%E2%80%89%25-gray) | | Lighthouse | Minimizes main-thread work | ๐ŸŸฅ 23.3ย s | ๐ŸŸฅ **22.8ย s** | ![โ†“ โˆ’2โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%922%E2%80%89%25-gray) | | Lighthouse | Total Blocking Time | ๐ŸŸฅ 8,990ย ms | ๐ŸŸฅ **8,550ย ms** | ![โ†“ โˆ’5โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%925%E2%80%89%25-gray) | | Lighthouse | Max Potential First Input Delay | ๐ŸŸฅ 3,150ย ms | ๐ŸŸฅ **3,320ย ms** | ![โ†‘ +6โ€‰%](https://img.shields.io/badge/%E2%86%91%20%2B6%E2%80%89%25-gray) | | Lighthouse | Reduce unused CSS | ๐ŸŸฅ Potential savings of 105ย KiB | ๐ŸŸฅ **Potential savings of 105ย KiB** | ![โ†‘ +50โ€‰%](https://img.shields.io/badge/%E2%86%91%20%2B50%E2%80%89%25-gray) | | Lighthouse | Server Backend Latencies | ๐ŸŸฉ 200ย ms | ๐ŸŸฉ **70ย ms** | ![โ†“ โˆ’63โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%9263%E2%80%89%25-gray) | | Lighthouse | Initial server response time was short | ๐ŸŸฉ Root document took 380ย ms | ๐ŸŸฉ **Root document took 300ย ms** | ![โ†“ โˆ’21โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%9221%E2%80%89%25-gray) | | Lighthouse | Time to Interactive | ๐ŸŸฅ 16.7ย s | ๐ŸŸฅ **16.8ย s** | ![โ†‘ +0โ€‰%](https://img.shields.io/badge/%E2%86%91%20%2B0%E2%80%89%25-gray) | | Lighthouse | Metrics | ๐ŸŸฉ 16696 | ๐ŸŸฉ **16764** | ![โ†‘ +0โ€‰%](https://img.shields.io/badge/%E2%86%91%20%2B0%E2%80%89%25-gray) | | Lighthouse | Network Round Trip Times | ๐ŸŸฉ 60ย ms | ๐ŸŸฉ **0ย ms** | ![โ†“ โˆ’97โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%9297%E2%80%89%25-gray) | | Lighthouse | Cumulative Layout Shift | ๐ŸŸฉ 0 | ๐ŸŸฉ **0** | ![โ†“ โˆ’100โ€‰%](https://img.shields.io/badge/%E2%86%93%20%E2%88%92100%E2%80%89%25-gray) | 489 other audits are unchanged.
BioPhoton commented 1 month ago

@matejchalk I now added tests to check the file system.

The reason why I did not do that i previous PR's was because our generator also tried to install the packages and our e2e setup does not allow this ATM.

So now i added a flag to skip the installation of the packages. I also added tests for the file system now as it can avoid errors with --skipInstall and the info messages for the skip flags.

Have a look.