Closed BioPhoton closed 1 month ago
π€¨ Code PushUp report has both improvements and regressions β compared target commit 45ba7a3d3f0d466b6f07bfb39b5044c7f1866b3e with source commit 7b6d7daa73c41589b85588f92de7a413b7bc87f0.
π΅οΈ See full comparison in Code PushUp portal π
π·οΈ Category | β Previous score | β Current score | π Score change |
---|---|---|---|
Performance | π΄ 43 | π‘ 54 | |
Custom checks | π‘ 67 | π‘ 67 | β |
Code coverage | π‘ 90 | π‘ 90 | β |
Security | π‘ 87 | π‘ 87 | β |
Updates | π‘ 78 | π‘ 78 | β |
Accessibility | π’ 91 | π’ 91 | β |
Best Practices | π’ 100 | π’ 100 | β |
SEO | π‘ 61 | π‘ 61 | β |
Bug prevention | π’ 100 | π’ 100 | β |
Code style | π’ 99 | π’ 99 | β |
This PR refactors the new E2E setup and made the existing codebase more robust.
It includes:
global-setup.verdaccio.ts
. Now we have 1 target,setup-deps
, to set up e2e dependencies.rm(dirName, { recursive: true, force: true, maxRetries: 2 });
It unfortunately also includes:
cli-e2e
to make it work. We lost testing of the registered command before:code-pushup ...
after:npx @code-pushup/cli ...
Implementation details
In my past attempts I was missing that params forwarding is off by default. Also the setup was too stable to make meaningful changes.
Targets are now correctly configures by using object to describe dependencies:
Task graph before
Task graph after