In neptune_cfd mode, some turbulent variables are not detected as such. At IMFT this is in particular the case for covariance_qfp whose default scheme is SOLU whilst it should be set to the order_scheme_pressure_turbulence scheme (UPWIND) like for other turbulent variables:
The issue comes from the XML node name which in this case is covariance_qfp_1 and not just covariance_qfp.
I propose a fix to the _isTurbulenceVariable method where instead of checking for strict equality between the XML node name and the list of expected names for turbulent variables, I treat these expected names as possible prefixes and check if the names starts with any of these prefixes.
This correctly fixes the issue as now all turbulent variables have the expected scheme.
YvanFournier
commented
4 months ago
In neptune_cfd mode, some turbulent variables are not detected as such. At IMFT this is in particular the case for
covariance_qfpwhose default scheme is SOLU whilst it should be set to theorder_scheme_pressure_turbulencescheme (UPWIND) like for other turbulent variables:The issue comes from the XML node name which in this case is
covariance_qfp_1and not justcovariance_qfp.I propose a fix to the
_isTurbulenceVariablemethod where instead of checking for strict equality between the XML node name and the list of expected names for turbulent variables, I treat these expected names as possible prefixes and check if the names starts with any of these prefixes.This correctly fixes the issue as now all turbulent variables have the expected scheme.