search

code-saturne / code_saturne

code_saturne public mirror
https://www.code-saturne.org
GNU General Public License v2.0
223 stars 82 forks source link

Possible wrong call of subroutine ustsnv #18

Closed paspro closed 5 years ago

paspro commented 6 years ago

I believe that the call of subroutine ustsnv in line 225 of file src/cfbl/cfmsfp.f90

! --- User source term call ustsnv & !========== ( nvar , nscal , ncepdp , ncesmp , & iu , & icepdc , icetsm , itypsm , & dt , & ckupdc , smacel , tsimp , tsexp )

is wrong because the two last arguments should be reversed as

! --- User source term call ustsnv & !========== ( nvar , nscal , ncepdp , ncesmp , & iu , & icepdc , icetsm , itypsm , & dt , & ckupdc , smacel , tsexp , tsimp )

YvanFournier commented 6 years ago

Yes, this seems to be a bug. this function is not used in compressible cases in the validation suite, and the compressible model is less widely used, so this may have been undetected for some time.

Thanks for the report.

YvanFournier commented 5 years ago

Fixed in master, v5.2, v5.1, and v5.0 branches.