tests: error in tests/cs_check_cdo.c / undeclared identifier 'cs_cdovb_diffusion_cost_flux_op'

[thierry-FreeBSD]

Trying to run `make check', I get this failure:

cc -DHAVE_CONFIG_H -I/usr/ports/science/code_saturne/work/code_saturne-5.3.0/libple -I../libple/src -I/usr/ports/science/code_saturne/work/code_saturne-5.3.0 -I../src/turb -I../src/mei -I../src/gui -I../src/cdo -I../src/mesh -I../src/atmo -I../src/alge -I../src/lagr -I../src/base -I../src/pprt -I../src/rayt -I../src/elec -I../src/bft -I../src/apps -I../src/fvm -I../src/user_examples -I../src/cfbl -I../src/comb -I../src/darc -I../src/ctwr -I../src/.libs -I../src/user -I../src/cogz -I/usr/local/include -DMPICH_SKIP_MPICXX -I/usr/local/include -I/usr/local/include/libxml2 -DLIBICONV_PLUG -DNDEBUG -std=c99 -funsigned-char -Wall -Wshadow -Wpointer-arith -Wmissing-prototypes -Wuninitialized -Wunused -O2 -pipe -DLIBICONV_PLUG -fstack-protector -fno-strict-aliasing -fopenmp=libomp -O2 -c ../tests/cs_check_cdo.c
../tests/cs_check_cdo.c:1110:46: error: use of undeclared identifier 'cs_cdovb_diffusion_cost_flux_op'
    cs_cdo_diffusion_pena_dirichlet(eqp, cm, cs_cdovb_diffusion_cost_flux_op,
                                             ^
../tests/cs_check_cdo.c:1119:5: warning: implicit declaration of function 'cs_cdovb_diffusion_weak_dirichlet' is invalid in C99 [-Wimplicit-function-declaration]
    cs_cdovb_diffusion_weak_dirichlet(eqp, cm, cs_cdovb_diffusion_cost_flux_op,
    ^
../tests/cs_check_cdo.c:1119:48: error: use of undeclared identifier 'cs_cdovb_diffusion_cost_flux_op'; did you mean 'cs_cdovb_diffusion_p0_face_flux'?
    cs_cdovb_diffusion_weak_dirichlet(eqp, cm, cs_cdovb_diffusion_cost_flux_op,
                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                               cs_cdovb_diffusion_p0_face_flux                                                                             
../src/cdo/cs_cdo_diffusion.h:504:1: note: 'cs_cdovb_diffusion_p0_face_flux' declared here
cs_cdovb_diffusion_p0_face_flux(const cs_cell_mesh_t     *cm,
^
../tests/cs_check_cdo.c:1129:5: warning: implicit declaration of function 'cs_cdovb_diffusion_wsym_dirichlet' is invalid in C99 [-Wimplicit-function-declaration]
    cs_cdovb_diffusion_wsym_dirichlet(eqp, cm, cs_cdovb_diffusion_cost_flux_op,
    ^
../tests/cs_check_cdo.c:1129:48: error: use of undeclared identifier 'cs_cdovb_diffusion_cost_flux_op'; did you mean 'cs_cdovb_diffusion_p0_face_flux'?
    cs_cdovb_diffusion_wsym_dirichlet(eqp, cm, cs_cdovb_diffusion_cost_flux_op,
                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                               cs_cdovb_diffusion_p0_face_flux                                                                             
../src/cdo/cs_cdo_diffusion.h:504:1: note: 'cs_cdovb_diffusion_p0_face_flux' declared here
cs_cdovb_diffusion_p0_face_flux(const cs_cell_mesh_t     *cm,
^
../tests/cs_check_cdo.c:1155:46: error: use of undeclared identifier 'cs_cdovb_diffusion_cost_flux_op'
    cs_cdo_diffusion_pena_dirichlet(eqp, cm, cs_cdovb_diffusion_cost_flux_op,
                                             ^
../tests/cs_check_cdo.c:1190:46: error: use of undeclared identifier 'cs_cdovb_diffusion_wbs_flux_op'
    cs_cdo_diffusion_pena_dirichlet(eqp, cm, cs_cdovb_diffusion_wbs_flux_op,
                                             ^
../tests/cs_check_cdo.c:1199:5: warning: implicit declaration of function 'cs_cdovb_diffusion_weak_dirichlet' is invalid in C99 [-Wimplicit-function-declaration]
    cs_cdovb_diffusion_weak_dirichlet(eqp, cm, cs_cdovb_diffusion_wbs_flux_op,
    ^
../tests/cs_check_cdo.c:1199:48: error: use of undeclared identifier 'cs_cdovb_diffusion_wbs_flux_op'; did you mean 'cs_cdo_diffusion_wbs_face_flux'?
    cs_cdovb_diffusion_weak_dirichlet(eqp, cm, cs_cdovb_diffusion_wbs_flux_op,
                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                               cs_cdo_diffusion_wbs_face_flux
../src/cdo/cs_cdo_diffusion.h:528:1: note: 'cs_cdo_diffusion_wbs_face_flux' declared here
cs_cdo_diffusion_wbs_face_flux(const cs_face_mesh_t      *fm,
^
../tests/cs_check_cdo.c:1207:5: warning: implicit declaration of function 'cs_cdovb_diffusion_wsym_dirichlet' is invalid in C99 [-Wimplicit-function-declaration]
    cs_cdovb_diffusion_wsym_dirichlet(eqp, cm, cs_cdovb_diffusion_wbs_flux_op,
    ^
../tests/cs_check_cdo.c:1207:48: error: use of undeclared identifier 'cs_cdovb_diffusion_wbs_flux_op'; did you mean 'cs_cdo_diffusion_wbs_face_flux'?
    cs_cdovb_diffusion_wsym_dirichlet(eqp, cm, cs_cdovb_diffusion_wbs_flux_op,
                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                               cs_cdo_diffusion_wbs_face_flux
../src/cdo/cs_cdo_diffusion.h:528:1: note: 'cs_cdo_diffusion_wbs_face_flux' declared here
cs_cdo_diffusion_wbs_face_flux(const cs_face_mesh_t      *fm,
^
4 warnings and 7 errors generated.
gmake[4]: *** [Makefile:1588: cs_check_cdo] Error 1

I cannot find where it is declared; any idea?

[YvanFournier]

Hello,

This is probably a rename or refactoring that was missed in the "make check"/tests section. I'll check this with the main CDO developer and check if we can activate "make check" in the defaul "make all" (there were issues trying this some months ago, but the underlying reasons should have been solved now).

[YvanFournier]

Was still present only in 5.3 branch.