code-saturne / code_saturne

code_saturne public mirror
https://www.code-saturne.org
GNU General Public License v2.0
223 stars 82 forks source link

Lagrangian: deposition without elimination and lack of deposition model #30

Closed mathrack closed 5 years ago

mathrack commented 5 years ago

https://github.com/code-saturne/code_saturne/blob/4748815a83f52cf6eb8d463ee772e0b956229635/src/lagr/cs_lagr_tracking.c#L1229

This line seems problematic when cs_glob_lagr_model->deposition = 0, which is the default setup. A workaround could be to call it only when

if (cs_glob_lagr_model->deposition == 1)

This is exactly what is done line 1197 for the deposition with elimination https://github.com/code-saturne/code_saturne/blob/4748815a83f52cf6eb8d463ee772e0b956229635/src/lagr/cs_lagr_tracking.c#L1197

YvanFournier commented 5 years ago

Fixed in v6.0, v5.3.2, v5.2.2, and v5.0.10.