search

code-saturne / code_saturne

code_saturne public mirror
https://www.code-saturne.org
GNU General Public License v2.0
218 stars 81 forks source link

Allow time-varying azimuth angle for photolysis reactions. #46

Closed mathrack closed 4 years ago

YvanFournier commented 5 years ago

Hello,

Does this add a functionality or fix an issue ? If we are adding an option, adding a start time (possibly instead of the test on idtvar) might be useful as the first iterations may be used to reach an initial "quasi-steady" state, and not have a physical meaning (a similar logic is used for example for ALE, Lagrangian stats, etc., though adding a consistant option for separating initialization and "real" computation would certainly help.

mathrack commented 5 years ago

Hello, I would say it fixes an issue. As it is, the azimuth angle does not change with time. It freezes the chemistry from the photolysis perspective. Maybe we should also adapt the computation of 'heuray' in atr1vf as it seems only compatible with idtvar=0. Cédric