search

code-saturne / code_saturne

code_saturne public mirror
https://www.code-saturne.org
GNU General Public License v2.0
218 stars 81 forks source link

ALE boundary condition for Free inlet/outlet type #51

Closed LucianoGarelli closed 3 years ago

LucianoGarelli commented 4 years ago

When using a deformable mesh and one of the boundaries conditions is free inlet/outlet there is no drop-down list to define the ALE BC. This issue arise in this post https://www.code-saturne.org/forum/viewtopic.php?f=2&t=2521#p13729

I test it CS version 5.10 and 6.1-alpha.

image

YvanFournier commented 4 years ago

Actually, the whole GUI-based handling of ALE assumes ALE is only controlled on walls, not other boundary types, due to sloppy work by the person who worked on this part of the GUI integration quite a few years ago already. This has already caused pain when updating the XML reader, as "wall" nodes for ALE appear on non-wall BC's.

For a clean solution, we will may need to modify the XML structure slightly, so ALE info is under the standard BC nodes, or at least uses a similar layout. Which then requires a "backwards compatibility" layer. Depending on the final fix, it may be too risky to apply to v6.0 and older versions, whose validation is well underway, but it should be fixed in v6.1.

PS: I edited the URL in your post, which did not link correctly to the desired page.

YvanFournier commented 3 years ago

Fixed by commit ab6fe2cc (starting with v6.2), merged in v6.0 branch (next v6.0.6) with commit b75d494a7.