code-saturne / code_saturne

code_saturne public mirror
https://www.code-saturne.org
GNU General Public License v2.0
225 stars 82 forks source link

Flag init_at_chem in case of restart without chemistry #56

Closed mathrack closed 4 years ago

mathrack commented 4 years ago

Hello,

When performing a restart from a simulation without chemistry, init_at_chem is set to ival(1) https://github.com/code-saturne/code_saturne/blob/d8dc66ef14c3c34457de4b5783f00d1a38b45efb/src/base/lecamp.f90#L344

For such a case (ierror is not zero), I suspect it would be better to set it to one, so that the fields are properly initialized in atiniv?

Thanks

EDIT: adding a suggestion for the modification

if (ichemistry.gt.0.or.iaerosol.gt.0) then
  rubriq = 'atmospheric_chem'
  itysup = 0
  nbval  = 1
  call restart_read_section_int_t(rp,rubriq,itysup,nbval,ival,ierror)
  if (ierror.eq.0) then
    init_at_chem = ival(1)
    if (init_at_chem.gt.0) then
      init_at_chem = 0
    endif
  else
    init_at_chem = 1
  endif
endif
mathrack commented 4 years ago

Fixed in trunk 7e2b2777989ce3fb3c924d74fdca2d5a6cd4b268 Could be merged in 6.0 and 5.0