search

code-saturne / code_saturne

code_saturne public mirror
https://www.code-saturne.org
GNU General Public License v2.0
218 stars 81 forks source link

Bug: Symmetric tensor diffusivity #64

Open AlexSkillen opened 3 years ago

AlexSkillen commented 3 years ago

The combination of turb_model->iturb = CS_TURB_NONE; and iturt(iscalt) = 10 (i.e. GGDH) leads to a segfault. I would expect the code to ignore iturt for laminar flow so the user can simply change one parameter when switching on the turbulence model. IMO, we should at least throw a warning that the settings are incompatible, rather than segfault.

It seems the issue stems from cpltur.f90 where a test for GGDH leads to an assumption of a symmetric tensor diffusivity for the thermal variable, when in reality the diffusivity is a scalar (my settings have diffusivity as variable in space and time, if it makes a difference).

YvanFournier commented 3 years ago

Hello,

In which version(s) do you observe this ?

AlexSkillen commented 3 years ago

6.x (tested 6.0 and 6.2). I've not been able to test the trunk yet. It also seems to be in 5.0

YvanFournier commented 3 years ago

OK, I'll check with the turbulence developers which way (warning, silent fix, ...) they prefer to fix this.