code100x / algorithmic-arena

91 stars 96 forks source link

Added Add-Solution functionality where user can add their submission to solution so other can see it. #44

Open ArpitBlagan opened 2 weeks ago

ArpitBlagan commented 2 weeks ago

On successful submission we can add it to solution where other can see his solution for better understanding. Video link: https://www.loom.com/share/9d85ed98ef3345a89fad7a518f2eed91?sid=2a94faab-a803-4f11-88b7-468e4bfee04b

SujithThirumalaisamy commented 2 weeks ago

Great work! I have a small suggession. Can we make the solution thing whole as a markdown? so that It will be easy and also we don't need to render the editor there. Your take on this bhaiya? @hkirat

ArpitBlagan commented 2 weeks ago

Thanks! I don't understand what you mean by 'making the whole thing Markdown' and which editor not to render. Can you please elaborate?

SujithThirumalaisamy commented 2 weeks ago

image Here we are rendering the code inside the code editor. I think we can get rid of that. And use a markdown to render the thing. Or something like a code snippet component

SujithThirumalaisamy commented 2 weeks ago

Also we can make the explanation section as markdown. So that people can bold and do some needed stuffs. Rather than a plain text

ArpitBlagan commented 2 weeks ago

Something like this at the time of adding solution and while showing the solution simple show the right part.

Screenshot 2024-06-17 at 11 02 24 AM
SujithThirumalaisamy commented 2 weeks ago

Something like this at the time of adding solution and while showing the solution simple show the right part.

Screenshot 2024-06-17 at 11 02 24 AM

Yeah this is the on. Great work. Are you merging this markdown editor?

ArpitBlagan commented 2 weeks ago

yup working on it. Thanks for your suggestion🙏🏼.

ArpitBlagan commented 2 weeks ago

check this out link: https://www.loom.com/share/5c87c764f38f4dbda9d6ab2dda7f5036?sid=fcccbea6-cb74-483f-a950-1b260cda4171

Now, after @hkirat bhaiya's reply, I am going to make a new PR with these changes.

SujithThirumalaisamy commented 2 weeks ago

check this out link: https://www.loom.com/share/5c87c764f38f4dbda9d6ab2dda7f5036?sid=fcccbea6-cb74-483f-a950-1b260cda4171

Now, after @hkirat bhaiya's reply, I am going to make a new PR with these changes.

This can be here. No worries

SujithThirumalaisamy commented 2 weeks ago

Looks great to me. We can also get the code component insted of the editor in the submission form also. Is it possible?

ArpitBlagan commented 2 weeks ago

We can do that, but I think an editor jsut like LeetCode would be better. This way, if a user wants to add comments or make other changes, they won't need to go back and update the code.

SujithThirumalaisamy commented 2 weeks ago

Yeah that is a valid point. Then this works fine.