feature: improve the captions settings ui and add keyboard shortcuts to change font size

code100x / cms

Repo for https://app.100xdevs.com/

https://app.100xdevs.com/

1.09k stars 1.6k forks source link

feature: improve the captions settings ui and add keyboard shortcuts to change font size #1526

Open Gourav-21 opened 1 month ago

Gourav-21 commented 1 month ago

Current UI The settings of caption looks really bad and there is no shortcut to change the size of fonts while watching the video, i have to open the settings everytime to change the size.

Suggestions

[ ] improve the ui of caption settings
[ ] add shortcuts to change size of font like its on youtube using - and +
[x] and add support for numpad to go forward and backward in video

shahkashish commented 1 month ago

To tackle the 2nd enhancement i.e. "add shortcuts to change size of font like its on youtube using - and +", we will have to

Add a State for current Subtitle Font Size.
Attach a keydown event listener to the component to capture the + and - keys.
Dynamically adjust the font size of the subtitles according to the current state of subtitle and the key that is pressed. above steps would let us complete the task

shahkashish commented 1 month ago

If you like the approach lmk and i'll start working on it, even if you have different views you can tell me.

Gourav-21 commented 4 weeks ago

@shahkashish yeah please go on

shahkashish commented 4 weeks ago

could you assign it to me? as it is mentioned that task should be assigned first and then i have to make PR