bug: Comment reply button

code100x / cms

Repo for https://app.100xdevs.com/

https://app.100xdevs.com/

1.06k stars 1.54k forks source link

bug: Comment reply button #780

Closed Azzam1503 closed 1 month ago

Azzam1503 commented 4 months ago

Clicking on the reply button in the comment section of videos redirects to the home page.

byte-king commented 4 months ago

Issue seems to be in the Comments.tsx file: (Attaching image for reference)

byte-king commented 4 months ago

Ideally, reply icon should not be inside the Link component , which is causing the redirection

byte-king commented 4 months ago

One solution could be to create a reply component which handles the replies. So that when the user clicks on reply icon/text, a new component is opened(similar to the public comment component) which gives user ability add a reply to the comment.

The reply component should have same properties as the comments component ( i.e. can be upvoted/downvoted and can also be replied further, creating a conversation chain)

Here, we will have to take care as to how will we be handling the comment text data behind the scenes.

Possible Solution:

Azzam1503 commented 4 months ago

So the reply button should act as a toggle for showing the reply comment component, whenever the user clicks on the reply button it will render another component.

byte-king commented 4 months ago

Yes. Similar to how reddit comments work

Chaitanya1672 commented 4 months ago

@Azzam1503 This issue is already fixed in PR #751 #742, if it is same issue you can close this issue.

RahulMishra0722 commented 4 months ago

@Azzam1503 This issue is already fixed in PR #751 #742, if it is same issue you can close this issue.

Stop gate keeping.

Chaitanya1672 commented 4 months ago

@Azzam1503 This issue is already fixed in PR #751 #742, if it is same issue you can close this issue.

Stop gate keeping.

Ok Rahul