code100x / tiplink

MIT License
175 stars 197 forks source link

[Feat] Implementation of Encryption of shares #136

Closed axatbhardwaj closed 2 months ago

axatbhardwaj commented 3 months ago

Todo:-

  1. encrypt shares using best encryption algo/method to encrypt

before starting with implementation would love to have a small research note (notion doc preferably) on how you've chosen a specific Algo/method for encryption and why

after the discussion would assign the issue then you can start implementing

it is not to scrutinize anyone just to make rational decision

Sahid-m commented 2 months ago

Do you mean encryption of private key shards or what is share in this context? Would like to work on this but need some clarity before researching for encryption algorithm

axatbhardwaj commented 2 months ago

Do you mean encryption of private key shards or what is share in this context? Would like to work on this but need some clarity before researching for encryption algorithm

yes

i meant the shares of private key only and i think it(documentation) is available on the notion doc present in project readme

Please let me know it isn't

Cheers !!

lakshayvaishnav commented 2 months ago

hey @axatbhardwaj , I've created a Notion document that outlines various encryption methods suitable for encrypting the shards in our project.

notion doc

Please take a look when you have a chance and let me know if you have any feedback!

axatbhardwaj commented 2 months ago

hey @axatbhardwaj , I've created a Notion document that outlines various encryption methods suitable for encrypting the shards in our project.

notion doc

Please take a look when you have a chance and let me know if you have any feedback!

Hi @lakshayvaishnav

Thank you for the doc and i would love to know in a few lines why should we use AES256 for symmetric encryption and not any other algo

lakshayvaishnav commented 2 months ago

hey @axatbhardwaj , I've created a Notion document that outlines various encryption methods suitable for encrypting the shards in our project. notion doc Please take a look when you have a chance and let me know if you have any feedback!

Hi @lakshayvaishnav

Thank you for the doc and i would love to know in a few lines why should we use AES256 for symmetric encryption and not any other algo

well , first of all it is really tough to crack because of its strong encryption , it is faster and efficient as compared to other algos so it wont slow down our dapp and lastly it is widely accepted and trusted by many other blockchain platforms and web3 projects.

axatbhardwaj commented 2 months ago

hey @axatbhardwaj , I've created a Notion document that outlines various encryption methods suitable for encrypting the shards in our project. notion doc Please take a look when you have a chance and let me know if you have any feedback!

Hi @lakshayvaishnav

Thank you for the doc and i would love to know in a few lines why should we use AES256 for symmetric encryption and not any other algo

well , first of all it is really tough to crack because of its strong encryption , it is faster and efficient as compared to other algos so it wont slow down our dapp and lastly it is widely accepted and trusted by many other blockchain platforms and web3 projects.

clone and look at the encryption branch from the repo

let's connect over discord if you have some doubts