search

code3z / vivaldi_mods_collection

Collection of Community Customizations for the Vivaldi Web Browser, from multiple sources.
2 stars 0 forks source link

Custom.py fails #2

Open code3z opened 3 years ago

code3z commented 3 years ago

I will be asking lonm about this and will figure it out.

code3z commented 3 years ago

home@chrx:~/vivaldi_mods_collection$ sudo python3 custom.py -i config.json WARNING - Uninstalling old mods WARNING - Installing mods ERROR - Failed to copy mod lonm/VivaldiMods/mods/advancedPanels.js ERROR - Failed to copy mod lonm/VivaldiMods/mods/autoSaveSessions.js ERROR - Failed to copy mod luetage/vivaldi_modding/import-export_themes.js ERROR - Failed to copy mod luetage/vivaldi_modding/backup-search-engines.js ERROR - Failed to copy mod lonm/VivaldiMods/mods/panel_actions.js

ortiza5 commented 3 years ago

That error makes me think that those files don't actually exist. Those should be file paths relative to the directory that contains custom.py and config.json.

code3z commented 3 years ago

They do exist, but unfortunately did not get committed to the repository. I am working on that. If you look at the error it is only the JS mods that throw errors. The script handles them differently.

Also I will add your modding repository to this, if that's okay. Does it have a license on it?

That error makes me think that those files don't actually exist. Those should be file paths relative to the directory that contains custom.py and config.json.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ortiza5 commented 3 years ago

Are those files in a folder called mods in the same directory that contains custom.py and config.json? That is where the script is expecting to find them.

Also I will add your modding repository to this, if that's okay. Does it have a license on it?

You can add any of my mods, but I am still updating some info in my repository. There is no license.

ortiza5 commented 3 years ago

It also might be a file permissions issue?

code3z commented 3 years ago

No, they are in subdirectories. I thought it handled subdirectories but I could be wrong. No liscense means a strict copyright in most countries. If you don't care how people use your mods you just need a "no rights reserved" and a disclaimer, see unliscense.org.

Are those files in a folder called mods in the same directory that contains custom.py and config.json? That is where the script is expecting to find them.

Also I will add your modding repository to this, if that's okay. Does it have a license on it?

You can add any of my mods, but I am still updating some info in my repository. There is no license.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

code3z commented 3 years ago

I think it may be an issue with incorrectly embedding another git repository.