code4business / freeproduct2

Magento2 extension that allows creating sales rules that add gift products.
64 stars 28 forks source link

Doesn't work update of minicart's count #12

Closed Mr-Bam closed 5 years ago

Mr-Bam commented 5 years ago

I have condition when subtotal price will be more than 1500. Problem is in when we add two products with price 849 (subtotal 1698), minicart count equal 2, but in general is 3, because we have add free product by condition. Also, if we add one product more, than it updates well. After that if we want to do subtotal price less then 1500, our free product will remove from cart, but count of minicart will not update. So, I think that we have to do update of minicart count every time when we add free product or remove. I have thought it can be in FreeProduct\Observer\RemoveGiftItems.php. But, unfortunately, I can't understand how to do it only by php without js. Here is screenshots: Here is correct image Here is wrong showing image Here is again correct image If we change qty of product to 1, we have the same situation like in the first screen.

domeglic commented 5 years ago

There is a new version in develop branch that we are currently testing that should fix this problem.

Mr-Bam commented 5 years ago

Okay. Thanks a lot. Good luck!

ср, 6 февр. 2019 г. в 14:27, Dominik Meglič notifications@github.com:

There is a new version in develop branch that we are currently testing that should fix this problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/code4business/freeproduct2/issues/12#issuecomment-461005874, or mute the thread https://github.com/notifications/unsubscribe-auth/AUUdSKE1a4nQAWKHMxme7Y3S9B5bINAZks5vKso9gaJpZM4akwZX .

domeglic commented 5 years ago

Should be fixed by #13