search

code4lib / 2021.code4lib.org

Website for Code4Lib 2021
https://2021.code4lib.org
4 stars 3 forks source link

Closes #145 #167

Closed Meng-V closed 3 years ago

Meng-V commented 3 years ago

Since the base-time is EST, the function "To your local time" need to test from a non-Eastern Time Zone place. To test, check on the pages http://localhost:4000/schedule/ and day1 - day4. Working on Day5 (The Post-conference half day workshops page)

dzoladz commented 3 years ago

@Meng-MiamiOH I should be able to review this today and provide some feedback.

dzoladz commented 3 years ago

I tried changing my OS timezone, as well as launching Chrome with a TZ= argument of America/Los_Angeles... but I wasn't able to get this solution to work.

Take a look at the last paragraph: https://shopify.github.io/liquid/filters/date/

If I’m interpreting this correctly, any timezone references are going to be one-time references to the computer building the site, not dynamic depending upon client. To my knowledge, this constraint on the now keyword cannot be overcome. This may not be a problem that Liquid is able to solve for us.

An alternative solution might be to use JS to detect the browser's timezone and convert.

dzoladz commented 3 years ago

I should also mention that there's no pressure to solve this problem during the 2021 conference cycle.

While it would be a nice feature to have, it's not going to cause any new problems by not having a timezone switcher available. Remote attendees have always needed to manually/mentally translate the schedule on the website into their local timezone. If we don't get it done for 2021, it's something to bump forward to 2022. If 2022 returns to an in-person conference, the livestream attendees would still benefit from being able to translate the schedule into their local timezone.