search

code4lib / 2024.code4lib.org

website for the 2024 Code4Lib conference
https://2024.code4lib.org/
4 stars 3 forks source link

quoted nickname causes syntax error #42

Closed phette23 closed 8 months ago

phette23 commented 8 months ago

On the schedule pages /schedule/day-1/ etc. there is a JS syntax error:

Uncaught SyntaxError: missing ) after argument list (at day-1/:506:61)

Issue is with a few names that have quoted nicknames in them:

<script>
    placeholderImage("clip-circle-speaker",
        " Ryan "Harpo" Harbert ",
        "/assets/img/nopics/nopic#.jpg",
        "Random placeholder for Ryan "Harpo" Harbert",
        10);
</script>

Need to change Jekyll to escape the string before inserting into the HTML.

phette23 commented 8 months ago

This bug is only evident on #41 when the speakers data is present.

phette23 commented 8 months ago

Seems to affect more than just the schedule, it happens on talk pages for these speakers as well plus the speakers page, basically anywhere a speaker image is used. These three files need to be fixed: