code4lib / 2024.code4lib.org

website for the 2024 Code4Lib conference
https://2024.code4lib.org/
4 stars 3 forks source link

0- and 1-based indexing in peri_conference include #71

Closed phette23 closed 2 months ago

phette23 commented 2 months ago

The peri-conference display uses both 0-based and 1-based indexing depending on where the data is coming from: https://github.com/code4lib/2024.code4lib.org/blob/c6117dcaf5513fe8ccf06e08c93be12d2c6c2a3f/_includes/homepage/peri_conference.html#L33-L51

The data-date="{{ site.data.conf.days[N].date-data }} in the HTML is 1-indexed and skips over a placeholder day while the various include parameters like link=site.data.conf.peri.dayN.am.link are 0-indexed.

We should do one or the other, not both. Probably the easiest, most intuitive thing is to make the site.data.conf.peri days be 1-indexed, as those aren't even in a list, they're named hashes.