search

code4lib / c4l18-keynote-statement

Code4Lib Community Statement in Support of Chris Bourg
https://code4lib.github.io/c4l18-keynote-statement/
7 stars 316 forks source link

Is it worth trying to alphabetize the list of signatories? #233

Closed matt-bernhardt closed 6 years ago

matt-bernhardt commented 6 years ago

Looking over how long this list has gotten, I wonder if it is worth trying to alphabetize the names? I'd be happy to take a crack at doing this - either just alphabetizing on the string as supplied by each signatory, or trying to apply a sort-by-last-name routine (which I realize might bring us into issues of how different communities prefer to do sorting).

No worries if we decide to leave things as is.

gmcharlt commented 6 years ago

I've no objection if you want to alphabetize, though I think the institutional ones (DLF, LITA, ACH, PKP, and the UVA Scholars' Lab) should end up kept together.

ranti commented 6 years ago

+1

mjgiarlo commented 6 years ago

Meh!

mjgiarlo commented 6 years ago

@matt-bernhardt @gmcharlt @ranti I whipped up https://github.com/code4lib/c4l18-keynote-statement/pull/246 so we could see what this looks like.

ranti commented 6 years ago

@mjgiarlo The groupings looks good to me. I appreciate the sorting by first name.

matt-bernhardt commented 6 years ago

I need to run a few errands at the moment, but I"m happy to put together a PR that implements the strategy laid out in #246 when I get back.

thatandromeda commented 6 years ago

I feel ++ on this in general but also I think it would be better to wait for a while - we are still getting a high volume of incoming signatories and will need to realphabetize before long; might be easier to wait until it's more stable.

mjgiarlo commented 6 years ago

@thatandromeda Do you think asking folks to add their names in sorted order is too high a bar? (Legit question, not asking it passive-aggressively.) If so, I think that's a good reason to wait.

gmcharlt commented 6 years ago

A suggestion once we decide we're ready to proceed - whoever prepares the final pull request, please give a shout here and in #general on the Slack to increase your chances that one of the folks adding signatures doesn't insta-create a merge conflict.

matt-bernhardt commented 6 years ago

I'm fine with waiting until things have calmed down a bit to try and tackle this.

nowviskie commented 6 years ago

I agree that it's a good idea to wait until things settle down!

ranti commented 6 years ago

I concur.

thatandromeda commented 6 years ago

@mjgiarlo I think it's too high a bar - for all that librarians are usually awesome at alphabetizing, we have an extremely large percentage of people whose first use of git/GitHub is signing this statement, and a bunch of merge conflicts.

(sorry I only just saw this - there are a LOT of emails from this repo in my inbox lately...)

mjgiarlo commented 6 years ago

Sounds good to me, @thatandromeda.

thatandromeda commented 6 years ago

OK, I now think it's a good idea; the rate of new PRs has declined significantly, and having the open issue is tempting people to put "add me" requests in comments rather than new issues, so I think the irritation of keeping the issue open now exceeds the irritation of closing it and having to redo it later ;)

mjgiarlo commented 6 years ago

@thatandromeda ha, ok, I can work on this in a wee bit.

mjgiarlo commented 6 years ago

@thatandromeda https://github.com/code4lib/c4l18-keynote-statement/pull/246 is ready for another look.

mjgiarlo commented 6 years ago

Thanks for creating this issue, @matt-bernhardt!