search

code4lib / planetcode4lib

Configuration for https://planet.code4lib.org/
11 stars 16 forks source link

line height? #10

Closed jrochkind closed 9 years ago

jrochkind commented 10 years ago

I find the line-height setting a bit too wide for readability. What do you think?

Current CSS, with 1.4em line-height:

screenshot 2014-10-20 21 21 04

Adjusted to only 1.3em:

screenshot 2014-10-20 21 20 53

Hmm, looking at it here, I'm not actually sure it's clear that 1.3em is better.... but something is making it hard for me to read, and it seemed at first to me a too spacey line height. Curious what you think.

Maybe I'll go to a design book and look for line height recommendations as a function of character size and/or line width.

jrochkind commented 10 years ago

Or maybe 1.35?

screenshot 2014-10-20 21 25 05

I'm not sure the original is 1.4, it may be even bigger, so maybe there's more room to be spacier but less than current too.

wdenton commented 10 years ago

I'll set it to 1.35 and we can see how it rolls.

wdenton commented 10 years ago

Wotcher think?

jrochkind commented 10 years ago

Live now? It still seems kind of spacey to me, but I could be wrong. better though.

wdenton commented 10 years ago

Live now. Sorry---I thought a pull had happened but it hadn't.

jrochkind commented 10 years ago

okay, it still still looks pretty spacey to me (I did hard refresh). You sure it's actually live now? Anyhow, i dunno, I'll leave it up to your judgement until I feel like spending more time on it to make a pull request I guess. :)

wdenton commented 9 years ago

Closing, but styling tweaks always welcome