code4lib / ruby-oai

a Ruby library for building OAI-PMH clients and servers
MIT License
62 stars 43 forks source link

Fixing incorrect redirection handling #13

Closed tjdett closed 12 years ago

tjdett commented 12 years ago

Redirection middleware was incorrectly configured, causing 301 redirects for trailing slash URLs to fail. (eg. /oai => /oai/)

This commit also substantially modifies the test ProviderServer so it can be extended for tests requiring a real (but differently behaving) server. The resulting should also be easier to understand.

codingfoo commented 12 years ago

+1 for this. I ran into this problem

tjdett commented 12 years ago

@cbeer Let me know if you need this rebased to the latest HEAD.

cbeer commented 12 years ago

Yes, please.

travisbot commented 12 years ago

This pull request passes (merged 1a87b29b into 98c430e0).

cbeer commented 12 years ago

Thanks, merged in.