search

code4lib / ruby-oai

a Ruby library for building OAI-PMH clients and servers
MIT License
62 stars 43 forks source link

replace URI with addressable #26

Closed atomotic closed 2 years ago

atomotic commented 11 years ago

what do you think about replacing URI with addressable? often i deal with domain containing "_" (that violates RFC 1034 supported by URI)

https://github.com/code4lib/ruby-oai/blob/master/lib/oai/client.rb#L85

require 'addressable/uri'
@base = Addressable::URI.parse base_url

ciao

barmintor commented 2 years ago

Thank you for this report - I'm sorry it was never addressed.

Per https://bugs.ruby-lang.org/issues/8241, Ruby's core URI parse has supported this behavior since Ruby 2.2, and this library currently requires Ruby >= 2.6.