code4lib / ruby-oai

a Ruby library for building OAI-PMH clients and servers
MIT License
62 stars 43 forks source link

Discrepancy between sample identifier format and real identifier #40

Closed gcolson closed 4 years ago

gcolson commented 9 years ago

Within OAI::Provider::Response::Identify, the sample identifier is set as r.sampleIdentifier "#{provider.prefix}:#{provider.identifier}" which conflicts with the syntax used here "#{provider.prefix}/#{record.id}". That should be modified to "#{provider.prefix}:#{record.id}"

jrochkind commented 4 years ago

I believe this has now been taken care of. Please feel free to re-open/re-file if it's still a problem.