search

code4lib / ruby-oai

a Ruby library for building OAI-PMH clients and servers
MIT License
62 stars 42 forks source link

Support testing on Rails 6.1 and 7.0 #90

Closed jrochkind closed 2 years ago

jrochkind commented 2 years ago

We don't have CI working on this repo (See #87), but I manually ran tests in Rails 5.2, 6.0. 6.1, and 7.0 -- it passed on all of them with no changes

BUT there was a deprecation notice in 7. I went ahead and fixed the deprecation notice (also confirming by manually running tests that still passed on all those versions).

This will at least allow manual testing on more recent Rails versions, as well as set the path for testing on recent Rails when we restore CI.

jrochkind commented 2 years ago

@mcritchlow and @orangewolf anyone interested in reviewing? If I don't hear from anyone, I may do a merge myself.

mcritchlow commented 2 years ago

This LGTM! Thanks for doing this @jrochkind