search

code4lib / shortimer

a webapp for code4lib jobs
http://jobs.code4lib.org
40 stars 15 forks source link

Add employer location information #23

Closed lawlesst closed 11 years ago

lawlesst commented 11 years ago

This is an attempt to add the employer location information requested in issue #11.

I added this as a post_save signal for Job. This way location data can be slowly added to the DB as people edit jobs. If we wanted to globally update existing employers, this could be modified to be a post_save signal on Employer.

The location information can be added to any template by passing the Employer object to the included location snippet.

The city, state and country are stored as strings using the existing Employer model. Further enhancements could include fetching the latitude and longitude for the city from Freebase and using that in some type of map display.

edsu commented 11 years ago

This is awesome. Sorry for the delay, I'm in the middle of looking at it.

edsu commented 11 years ago

The more I think about it the more I like the idea of tying the location to the Job rather than to the Employer. I say this because I've seen my fair share of job postings where the place of work isn't exactly where the HQ is. I'm going to use your branch but shuffle a few things around. More shortly :-)

jodischneider commented 11 years ago

Pulling the default location from the employer, and enabling override, seems optimal to me, FWIW.

On Fri, Feb 22, 2013 at 11:05 AM, Ed Summers notifications@github.comwrote:

The more I think about it the more I like the idea of tying the location to the Job rather than to the Employer. I say this because I've seen my fair share of job postings where the place of work isn't exactly where the HQ is. I'm going to use your branch but shuffle a few things around. More shortly :-)

— Reply to this email directly or view it on GitHubhttps://github.com/code4lib/shortimer/pull/23#issuecomment-13950720.

edsu commented 11 years ago

Yes, exactly. I was going to add a suggest input box to the Job edit page for location that would (if all goes as expected) auto-populate when the Employer was selected using Ted's logic.

lawlesst commented 11 years ago

This all sounds good to me. Let me know if there's anything you would like me to rework.

edsu commented 11 years ago

I'm in the middle of deploying this right now. I think there are still some kinks to work out. But it's a start. I pulled in the lon/lat for locations btw, which could be fun if someone wanted to play around with maps LeafletJS anyone? :smile: